RFE: please provide suppot for latest 1.x maturin

[kloczek]

rpds/pyproject.toml

Lines 1 to 2 in 373e9d7

	[build-system]
	requires = ["maturin>=0.14,<0.15"]

Just tested with maturin 1.1.0 and on first look module builds correctly

+ /usr/bin/python3 -sBm build -w --no-isolation
* Getting build dependencies for wheel...
* Building wheel...
Running `maturin pep517 build-wheel -i /usr/bin/python3 --compatibility off`
    Updating crates.io index
  Downloaded target-lexicon v0.12.6
  Downloaded pyo3-macros v0.18.1
  Downloaded quote v1.0.23
  Downloaded once_cell v1.17.1
  Downloaded proc-macro2 v1.0.51
  Downloaded pyo3-macros-backend v0.18.1
  Downloaded pyo3-build-config v0.18.1
  Downloaded unicode-ident v1.0.6
  Downloaded windows_x86_64_gnullvm v0.42.1
  Downloaded libc v0.2.139
  Downloaded windows_i686_msvc v0.42.1
  Downloaded pyo3-ffi v0.18.1
  Downloaded windows-targets v0.42.1
  Downloaded windows_x86_64_gnu v0.42.1
  Downloaded windows_aarch64_gnullvm v0.42.1
  Downloaded pyo3 v0.18.1
  Downloaded windows_aarch64_msvc v0.42.1
  Downloaded windows_x86_64_msvc v0.42.1
  Downloaded windows_i686_gnu v0.42.1
  Downloaded windows-sys v0.45.0
  Downloaded archery v0.5.0
  Downloaded rpds v0.13.0
  Downloaded 22 crates (8.2 MB) in 1.34s (largest was `windows-sys` at 2.6 MB)
📦 Including license file "/home/tkloczko/rpmbuild/BUILD/rpds-0.7.1/LICENSE"
🔗 Found pyo3 bindings with abi3 support for Python ≥ 3.8
🐍 Not using a specific python interpreter
📡 Using build options features from pyproject.toml
   Compiling target-lexicon v0.12.6
   Compiling autocfg v1.1.0
   Compiling once_cell v1.17.1
   Compiling proc-macro2 v1.0.51
   Compiling unicode-ident v1.0.6
   Compiling quote v1.0.23
   Compiling libc v0.2.139
   Compiling syn v1.0.109
   Compiling parking_lot_core v0.9.7
   Compiling smallvec v1.10.0
   Compiling cfg-if v1.0.0
   Compiling scopeguard v1.1.0
   Compiling static_assertions v1.1.0
   Compiling unindent v0.1.11
   Compiling indoc v1.0.9
   Compiling archery v0.5.0
   Compiling rpds v0.13.0
   Compiling lock_api v0.4.9
   Compiling memoffset v0.8.0
   Compiling pyo3-build-config v0.18.1
   Compiling parking_lot v0.12.1
   Compiling pyo3-macros-backend v0.18.1
   Compiling pyo3-ffi v0.18.1
   Compiling pyo3 v0.18.1
   Compiling pyo3-macros v0.18.1
   Compiling rpds-py v0.7.1 (/home/tkloczko/rpmbuild/BUILD/rpds-0.7.1)
    Finished release [optimized] target(s) in 58.61s
📖 Found type stub file at rpds.pyi
📦 Built wheel for abi3 Python ≥ 3.8 to /home/tkloczko/rpmbuild/BUILD/rpds-0.7.1/target/wheels/rpds_py-0.7.1-cp38-abi3-linux_x86_64.whl
/home/tkloczko/rpmbuild/BUILD/rpds-0.7.1/target/wheels/rpds_py-0.7.1-cp38-abi3-linux_x86_64.whl
Successfully built rpds_py-0.7.1-cp38-abi3-linux_x86_64.whl

[kloczek]

Just checked what has been produced as DSO module

[tkloczko@pers-jacek SPECS]$ size rpds.abi3.so
   text    data     bss     dec     hex filename
 512285   22064     424  534773   828f5 rpds.abi3.so

So out of ~1.7KB source file has been produced +0.5MB DSO.
is it really worth to use rust in such cases? 🤔

[Julian]

The build system is an internal implementation detail. I'm happy to see a PR if you fully test and know it works, otherwise it's not a priority to upgrade as it's not end-user facing.

[kloczek]

Yes I've tested that using below patch and above log is part of my rpm package build log.

--- a/pyproject.toml
+++ b/pyproject.toml
@@ -1,5 +1,5 @@
 [build-system]
-requires = ["maturin>=0.14,<0.15"]
+requires = ["maturin>=0.14"]
 build-backend = "maturin"

 [project]