make autocaptialization experimental and turn off by default

crate · Feb 27, 2017 · 4774fa3 · 4774fa3
1 parent b5e1869
commit 4774fa3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -5,11 +5,12 @@ Changes for crash
 Unreleased
 ==========
 
- - Expanded the list of keywords used by autocompletion and 
+ - Expanded the list of keywords used by autocompletion and
    autocapitlization.
 
- - Automatically capitalize keywords while typing,
-   e.g. ``select`` -> ``SELECT``
+ - Automatically capitalize keywords while typing, e.g. ``select`` -> ``SELECT``
+   **This feature is experimental and turned off by default. It may be removed
+   in future versions!**
 
  - Automatically suggest and complete to ``UPPERCASE`` keywords
    when using autocomplete.

diff --git a/docs/cli.txt b/docs/cli.txt
@@ -40,8 +40,9 @@ The ``crash`` binary supports several command line arguments.
 |                                       | overlay for suggestions.                         |
 |                                       | Disabling autocomplete removes this limitation.  |
 +---------------------------------------+--------------------------------------------------+
-| ``-C`` , ``--no-autocapitalize``      | Disable automatic capitalization of SQL keywords |
-|                                       | while typing.                                    |
+| ``-c`` , ``--autocapitalize``         | Enable automatic capitalization of SQL keywords  |
+|                                       | while typing. This feature is experimental and   |
+|                                       | may be removed in future versions.               |
 +---------------------------------------+--------------------------------------------------+
 
 Example Usage

diff --git a/src/crate/crash/command.py b/src/crate/crash/command.py
@@ -134,10 +134,10 @@ def _conf_or_default(key, value):
                         dest='autocomplete',
                         default=_conf_or_default('autocomplete', True),
                         help='use -A to disable SQL autocompletion')
-    parser.add_argument('-C', '--no-autocapitalize', action='store_false',
+    parser.add_argument('-a', '--autocapitalize', action='store_true',
                         dest='autocapitalize',
-                        default=_conf_or_default('autocapitalize', True),
-                        help='use -C to disable automatic capitalization of SQL keywords')
+                        default=False,
+                        help='use -a to enable experimental auto-capitalization of SQL keywords')
 
     parser.add_argument('--history', type=str,
                         help='the history file to use', default=HISTORY_PATH)