fixed autocapitalize cursor issue #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
suggested changes
Feb 17, 2017
src/crate/crash/repl.py
Outdated
| if self.last_changed and self.is_prefix(current_line.lower(), self.last_changed.lower()): | ||
| diff = len(self.last_changed) - len(current_line) | ||
| current_line = self.last_changed + current_line[diff:] | ||
|
|
||
| new_line = re.sub(self.KEYWORD_RE, self.keyword_replacer, current_line) | ||
| new_line = re.sub(self.KEYWORD_RE, self.keyword_replacer, \ |
There was a problem hiding this comment.
\ not required when having function arguments separated by newlines
same below
There was a problem hiding this comment.
also, I think all arguments would fit into a single line
CHANGES.txt
Outdated
| @@ -5,6 +5,9 @@ Changes for crash | |||
| Unreleased | |||
| ========== | |||
|
|
|||
| - Fixed issue that caused the autocapitalization to move the cursor | |||
There was a problem hiding this comment.
we must not forget to remove that line when doing a release
There was a problem hiding this comment.
should I remove it from the changelog ?
5 similar comments
m-kharbat
force-pushed
the
meri/fix-cursor
branch
from
543cd94
to
7b3e2f6
Compare
5 similar comments
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
=======================================
Coverage 81.11% 81.11%
=======================================
Files 16 16
Lines 1859 1859
=======================================
Hits 1508 1508
Misses 351 351
Continue to review full report at Codecov.
|
m-kharbat
force-pushed
the
meri/fix-cursor
branch
2 times, most recently
from
9e3ae95
to
451b1fd
Compare
|
@m-kharbat please wait for green CI |
m-kharbat
force-pushed
the
meri/fix-cursor
branch
from
f14c266
to
980778c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
select * from foothen move the cursor back to*and adddate_truncit will capitalize DATE but not lowercase it again when typing further. http://g.recordit.co/hTB7BCuB0C.gif