Stopped autocapitalisation of backslash preceded keywords #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
==========================================
+ Coverage 81.11% 81.17% +0.06%
==========================================
Files 16 16
Lines 1859 1865 +6
==========================================
+ Hits 1508 1514 +6
Misses 351 351
Continue to review full report at Codecov.
|
1 similar comment
chaudum
suggested changes
Feb 23, 2017
src/crate/crash/repl.py
Outdated
| @@ -222,7 +222,7 @@ def is_multiline(): | |||
|
|
|||
| class Capitalizer: | |||
|
|
|||
| KEYWORD_RE = r'(?:"\w+)|(?:\'\w+)|\w+' | |||
| KEYWORD_RE = r'(?:"\w+)|(?:\'\w+)|(?:\\\w+)|\w+' | |||
There was a problem hiding this comment.
this does not catch the case \format dynamic
You need to disable auto-captialisation when line starts with \
src/crate/crash/test_repl.py
Outdated
| @@ -83,6 +83,10 @@ def test_capitalize(self): | |||
| self.capitalizer(buffer) | |||
| self.assertEqual(u'CREATE TABLE test\n(a BOOLEAN, b STRING, c INTEGER)', buffer.text) | |||
|
|
|||
| text = u'\select' | |||
autophagy
changed the title
chaudum
suggested changes
Feb 23, 2017
src/crate/crash/repl.py
Outdated
| if self.last_changed and self.is_prefix(current_line[:cursor_position].lower(), self.last_changed.lower()): | ||
| diff = len(self.last_changed) - len(current_line) | ||
| current_line = self.last_changed + current_line[diff:] | ||
| if current_line[0] != '\\': |
There was a problem hiding this comment.
code style: make as little indentation (nested if blocks) as possible
if current_line.startswith('\\'):
returnthen you can leave the indentation of the rest as is
1 similar comment
1 similar comment
autophagy
force-pushed
the
mika/keywordsBackslash
branch
from
f5b8ff3
to
fd4334c
Compare
autophagy
changed the title
chaudum
approved these changes
Feb 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.