Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't print the whole stack trace on Connection error. #190

Merged
merged 1 commit into from
Jun 27, 2017

Conversation

matriv
Copy link
Contributor

@matriv matriv commented Jun 27, 2017

It now looks like that:

➭ bin/crash -v --verify-ssl true --cert-file /tmp/certs/marios.crt --key-file /tmp/certs/marios.key --ca-cert-file /tmp/certs/rootCA.crt --hosts https://127.0.0.1:4200 -U unknonwn
/Users/matriv/crate/crash/eggs/urllib3-1.14-py3.6.egg/urllib3/connection.py:266: SubjectAltNameWarning: Certificate for 127.0.0.1 has no `subjectAltName`, falling back to check for a `commonName` for now. This feature is being removed by major browsers and deprecated by RFC 2818. (See https://github.com/shazow/urllib3/issues/497 for details.)`
  SubjectAltNameWarning
401 Client Error: Unauthorized

@matriv matriv requested a review from mfussenegger June 27, 2017 10:42
@coveralls
Copy link

coveralls commented Jun 27, 2017

Coverage Status

Coverage decreased (-0.005%) to 38.904% when pulling 3f42f9d on mt/remove-stacktrace into 628e6c8 on master.

@codecov-io
Copy link

codecov-io commented Jun 27, 2017

Codecov Report

Merging #190 into master will decrease coverage by 0.11%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
- Coverage    82.1%   81.98%   -0.12%     
==========================================
  Files          16       16              
  Lines        1906     1910       +4     
==========================================
+ Hits         1565     1566       +1     
- Misses        341      344       +3
Impacted Files Coverage Δ
src/crate/crash/command.py 84.48% <40%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 628e6c8...d0b2a76. Read the comment docs.

@matriv matriv requested review from chaudum and removed request for mfussenegger June 27, 2017 11:36
CHANGES.txt Outdated
@@ -5,6 +5,8 @@ Changes for crash
Unreleased
==========

- Removed printing of full stack trace in case of connection error.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Print only error message instead of full stacktrack in case of connection error.

@matriv matriv merged commit d0b2a76 into master Jun 27, 2017
@coveralls
Copy link

coveralls commented Jun 27, 2017

Coverage Status

Coverage decreased (-0.005%) to 38.904% when pulling c830e96 on mt/remove-stacktrace into 628e6c8 on master.

@matriv matriv deleted the mt/remove-stacktrace branch June 27, 2017 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants