added session toolbar #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikethebeer
commented
Aug 9, 2017
mikethebeer
commented
- shows the current session user
- shows the handler nodes connected with
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
==========================================
- Coverage 83.05% 82.28% -0.78%
==========================================
Files 16 17 +1
Lines 2066 2105 +39
==========================================
+ Hits 1716 1732 +16
- Misses 350 373 +23
Continue to review full report at Codecov.
|
mfussenegger
requested changes
Aug 16, 2017
src/crate/crash/layout.py
Outdated
| 'create_layout', | ||
| ) | ||
|
|
||
| def create_layout(message='', lexer=None, |
There was a problem hiding this comment.
please add a comment explaining the difference to create_prompt_layout
src/crate/crash/layout.py
Outdated
| from prompt_toolkit.layout.margins import PromptMargin, ConditionalMargin | ||
| from prompt_toolkit.layout.utils import token_list_width | ||
|
|
||
| __all__ = ( |
There was a problem hiding this comment.
no need to define __all__ as we don't do a import *
src/crate/crash/repl.py
Outdated
| if cmd.is_conn_avaliable(): | ||
| active_servers = cmd.connection.client.active_servers | ||
| active_servers = [n.replace('http://', '') for n in active_servers] | ||
| active_servers = [n.replace('https://', '') for n in active_servers] |
There was a problem hiding this comment.
could use generator expressions instead of list comprehensions to avoid the copying
4 similar comments
added 3 commits
August 18, 2017 13:51
* shows the current session user * shows the handler nodes connected with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.