Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for multiline table headers in the tabular output format #218

Merged
merged 1 commit into from
Aug 17, 2017

Conversation

Taliik
Copy link
Member

@Taliik Taliik commented Aug 17, 2017

cr> select 1 = (select 2);
+----------------+
| (1 = (SELECT 2 |
|                |
| ))             |
+----------------+
| FALSE          |
+----------------+
SELECT 1 row in set (0.003 sec)
cr>

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 83.569% when pulling 38c9d5d on f/crash-output-layout-fix into 6a6070a on master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 83.569% when pulling 38c9d5d on f/crash-output-layout-fix into 6a6070a on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 83.569% when pulling 38c9d5d on f/crash-output-layout-fix into 6a6070a on master.

@coveralls
Copy link

coveralls commented Aug 17, 2017

Coverage Status

Coverage decreased (-0.1%) to 83.569% when pulling 38c9d5d on f/crash-output-layout-fix into 6a6070a on master.

@codecov-io
Copy link

codecov-io commented Aug 17, 2017

Codecov Report

Merging #218 into master will decrease coverage by 0.12%.
The diff coverage is 82.6%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
- Coverage   83.69%   83.56%   -0.13%     
==========================================
  Files          16       16              
  Lines        1999     2051      +52     
==========================================
+ Hits         1673     1714      +41     
- Misses        326      337      +11
Impacted Files Coverage Δ
src/crate/crash/tabulate.py 58.79% <82.6%> (+2.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a6070a...e64f141. Read the comment docs.

Copy link

@mikethebeer mikethebeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

CHANGES.txt Outdated
@@ -5,6 +5,8 @@ Changes for crash
Unreleased
==========

- added multiline support

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would write it like this:

added support for multiline table headers in the tabular output format.

@Taliik Taliik changed the title added multiline support added support for multiline table headers in the tabular output format Aug 17, 2017
@coveralls
Copy link

coveralls commented Aug 17, 2017

Coverage Status

Coverage decreased (-0.1%) to 83.569% when pulling 2051640 on f/crash-output-layout-fix into 6a6070a on master.

1 similar comment
@coveralls
Copy link

coveralls commented Aug 17, 2017

Coverage Status

Coverage decreased (-0.1%) to 83.569% when pulling 2051640 on f/crash-output-layout-fix into 6a6070a on master.

Copy link

@mikethebeer mikethebeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Taliik Taliik merged commit 2d3fcec into master Aug 17, 2017
@Taliik Taliik deleted the f/crash-output-layout-fix branch August 17, 2017 09:50
@Taliik Taliik restored the f/crash-output-layout-fix branch August 24, 2017 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants