crash multiline header fix #222
Conversation
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
==========================================
+ Coverage 82.75% 83.04% +0.29%
==========================================
Files 17 17
Lines 2064 2165 +101
==========================================
+ Hits 1708 1798 +90
- Misses 356 367 +11
Continue to review full report at Codecov.
|
| # wcswidth and _visible_width don't count invisible characters; | ||
| # padfn doesn't need to apply another correction | ||
| if strings[0] == '': | ||
| strings[0] = ' ' |
There was a problem hiding this comment.
This seems a bit hacky. Can't we enable support for empty string padding in padfn?
There was a problem hiding this comment.
Are these the only changes from the old multiline formatting code?
There was a problem hiding this comment.
Yes it kinda is. I don't think padfn supports empty strings, but i will have another look to see if i can find a better solution.
yes these are the only changes.
CHANGES.txt
Outdated
| @@ -5,6 +5,8 @@ Changes for crash | |||
| Unreleased | |||
| ========== | |||
|
|
|||
| - added back support for multiline table headers | |||
There was a problem hiding this comment.
You could capitalize the first letter here.
Taliik
force-pushed
the
f/crash-multiline-header-fix
branch
from
bcfbf13
to
2e476c5
Compare
fixed the problem with the formatting if the first row was empty, in line 585 & 586
also added some formatting tests