rename CrateCmd to CrateShell #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make it more descriptive
chaudum
force-pushed
the
h/rename-command
branch
from
fdac3fb
to
b507261
Compare
mfussenegger
approved these changes
Apr 13, 2018
src/crate/crash/command.py
Outdated
| @@ -240,15 +248,19 @@ def __init__(self, | |||
| } | |||
| self.commands.update(built_in_commands) | |||
| self.logger = ColorPrinter(is_tty) | |||
|
|
|||
| self.output_writer = output_writer or \ | |||
| OutputWriter(PrintWrapper(), is_tty) | |||
There was a problem hiding this comment.
I think we should add a setup.cfg pycodestyle entry and raise the line-length to something like 88 (while still aiming for 80 in most cases)
Breaks like this imho hurt readability more than they improve it. See also https://github.com/ambv/black#line-length
There was a problem hiding this comment.
It's better than it was before, though, I think. but I agree, that it makes sense to put it into a single line for readability.
matriv
approved these changes
Apr 13, 2018
so that there is only a single place where connections are created
for clarification of usage
chaudum
force-pushed
the
h/rename-command
branch
from
89bc927
to
ceca8fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and other cleanups