Upgrade prompt toolkit to 2.0.x #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfussenegger
force-pushed
the
j/prompt-toolkit-2
branch
2 times, most recently
from
1fe90fc
to
6652397
Compare
mfussenegger
changed the title
mfussenegger
force-pushed
the
j/prompt-toolkit-2
branch
from
6652397
to
8e85717
Compare
chaudum
approved these changes
Jun 11, 2019
setup.py
Outdated
| @@ -30,7 +30,7 @@ | |||
| 'Pygments>=2.0', | |||
| 'crate>=0.22.0', | |||
| 'appdirs>=1.2,<2.0', | |||
| 'prompt-toolkit>=1.0,<1.1' | |||
| 'prompt-toolkit>=2.0' | |||
There was a problem hiding this comment.
Do you think it's save to allow everything >= 2.0?
The versions.cfg specifies 2.0.9, so we don't test with greater versions.
There was a problem hiding this comment.
Added a <3.0 constraint (dev branch is on 3.0, so it is unlikely that there are going to be 2.1 releases and if so I think they won't contain breaking changes.)
mfussenegger
force-pushed
the
j/prompt-toolkit-2
branch
from
8e85717
to
45d3bb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.