Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change directory structure, switch from zope.testrunner to unittest #297

Merged
merged 2 commits into from
Aug 2, 2019

Conversation

mfussenegger
Copy link
Member

Main motivation is to be able to run tests from within an editor
directly using something like vim-test

Due to the self.crate_host hack that was in the test_command file,
those tests couldn't be run standalone as they required the monkey
patching done in the test_suite method.

It also gets rid of a few warnings caused by the older zope testing
version.

@mfussenegger mfussenegger force-pushed the j/directory-structure branch 2 times, most recently from 6c897f4 to 61e33ba Compare August 2, 2019 07:30
@mfussenegger mfussenegger marked this pull request as ready for review August 2, 2019 07:36
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tox is still using the zope-testrunner. Do you want to remove it there as well?

tox.ini Outdated
@@ -9,4 +9,4 @@ deps =
zope.testrunner
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this line can be removed as well then.

@mfussenegger mfussenegger merged commit d181979 into master Aug 2, 2019
@mfussenegger mfussenegger deleted the j/directory-structure branch August 2, 2019 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants