Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve visual representation of SQL statements #302

Merged
merged 1 commit into from Sep 25, 2019
Merged

Improve visual representation of SQL statements #302

merged 1 commit into from Sep 25, 2019

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Sep 17, 2019

Summary of the changes / Why this is an improvement

This commit changes the lexer for tokenizing the user input from the
generic SqlLexer to the more specific PostgresLexer.

Additionally the color scheme has been changed from a custom on to
"terminal style", meaning that it will pick up the colors of the
terminal emulator (http://pygments.org/docs/styles/#ansiterminalstyle).

Screenshots

Old

2019-09-17-213342_1223x1062_scrot

New

2019-09-17-213053_1190x1029_scrot

Checklist

  • CLA is signed

Copy link
Member

@mfussenegger mfussenegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The dark blue colors had been bothering me as well :)

@chaudum
Copy link
Contributor Author

chaudum commented Sep 25, 2019

+1 The dark blue colors had been bothering me as well :)

Do you think this deserves a changelog entry?

@mfussenegger
Copy link
Member

Do you think this deserves a changelog entry?

Can't hurt. 👍 for adding an entry

This commit changes the lexer for tokenizing the user input from the
generic SqlLexer to the more specific PostgresLexer.

Additionally the color scheme has been changed from a custom on to
"terminal style", meaning that it will pick up the colors of the
terminal emulator (http://pygments.org/docs/styles/#ansiterminalstyle).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants