Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply and enforce isort on codebase #305

Merged
merged 1 commit into from Oct 3, 2019
Merged

Apply and enforce isort on codebase #305

merged 1 commit into from Oct 3, 2019

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Oct 1, 2019

Summary of the changes / Why this is an improvement

Using isort for consistent import ordering and formatting.

mfussenegger
mfussenegger approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@mfussenegger mfussenegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure I'll run into test failures because I'll miss adhering to the right order, but if you think it improves things fine for me.

@chaudum chaudum merged commit f4d33e7 into master Oct 3, 2019
@chaudum chaudum deleted the h/isort branch October 3, 2019 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfussenegger mfussenegger mfussenegger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chaudum @mfussenegger