Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: implement heartbeat to keep connection alive #313

Closed
wants to merge 1 commit into from

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Feb 10, 2020

Summary of the changes / Why this is an improvement

@autophagy @mfussenegger Is the keep-alive feature of crash still a thing? It has been lying around on my local checkout for some time now and I am wondering whether I should get it over the finish line.

Checklist

  • CLA is signed

@mfussenegger
Copy link
Member

I'm not sure. psql suffers from the same problem when using it to connect to a cloud cluster. So I wonder if we can come up a solution that doesn't involve patching all clients.

@chaudum
Copy link
Contributor Author

chaudum commented Feb 10, 2020

I'm not sure. psql suffers from the same problem when using it to connect to a cloud cluster. So I wonder if we can come up a solution that doesn't involve patching all clients.

The very specific problem, however, occurs when using Azure Loadbalancer, which has an idle timeout of 4-30 minutes, but it is not possible to deactivate connection reset.
https://docs.microsoft.com/en-us/azure/load-balancer/load-balancer-tcp-idle-timeout#tcp-idle-timeout
load-balancer/load-balancer-tcp-reset

@mfussenegger
Copy link
Member

Instead of doing query-heartbeats we could also enable TCP-keep-alive.

urllib3 docs has an example how to set that

@chaudum chaudum closed this Sep 8, 2020
@chaudum
Copy link
Contributor Author

chaudum commented Sep 8, 2020

Instead of doing query-heartbeats we could also enable TCP-keep-alive.

urllib3 docs has an example how to set that

I will open an PR on crate-python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants