Migrate from Travis CI to GitHub Actions #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
amo/modernize-ci
branch
16 times, most recently
from
0f5f032
to
69d31d1
Compare
amotl
commented
Jan 12, 2021
.github/workflows/tests.yml
Outdated
Comment on lines
63
to
71
| - name: Upload coverage | ||
| continue-on-error: true | ||
| run: | | ||
|
|
||
| # Run all commands, but don't mask exit code | ||
| exitcode=0; on_error() { exitcode=1; }; trap on_error ERR | ||
|
|
||
| # Upload to Coveralls | ||
| php-coveralls --coverage_clover=build/logs/clover.xml -v | ||
|
|
||
| # Upload to Scrutinizer | ||
| ocular code-coverage:upload --format=php-clover build/logs/clover.xml | ||
|
|
||
| exit $exitcode |
There was a problem hiding this comment.
We will yet have to provide authentication tokens for Coveralls and Scrutinizer to GHA before integrating this.
There was a problem hiding this comment.
amotl
force-pushed
the
amo/modernize-ci
branch
from
69d31d1
to
4b2d0d2
Compare
seut
reviewed
Jan 12, 2021
|
Hi @matthijskrul, after integrating this, it will probably unlock the possibility to finally merge #97. Cheers, |
nomicode
reviewed
Jan 12, 2021
|
needs a travis bump @amotl [edit: it needs travis removed from the branch protections or the check will always block the PR] |
amotl
force-pushed
the
amo/modernize-ci
branch
from
4b2d0d2
to
35926d2
Compare
Also, add testing for PHP 7.4.
amotl
force-pushed
the
amo/modernize-ci
branch
from
35926d2
to
36f7ddd
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
this patch removes Travis CI and adds GitHub Actions instead. This CI setup is really fast.
With kind regards,
Andreas.