-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from Travis CI to GitHub Actions #98
Conversation
0f5f032
to
69d31d1
Compare
.github/workflows/tests.yml
Outdated
- name: Upload coverage | ||
continue-on-error: true | ||
run: | | ||
|
||
# Run all commands, but don't mask exit code | ||
exitcode=0; on_error() { exitcode=1; }; trap on_error ERR | ||
|
||
# Upload to Coveralls | ||
php-coveralls --coverage_clover=build/logs/clover.xml -v | ||
|
||
# Upload to Scrutinizer | ||
ocular code-coverage:upload --format=php-clover build/logs/clover.xml | ||
|
||
exit $exitcode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will yet have to provide authentication tokens for Coveralls and Scrutinizer to GHA before integrating this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
69d31d1
to
4b2d0d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool, thanks! Just added a comment related to the composer.lock.
Hi @matthijskrul, after integrating this, it will probably unlock the possibility to finally merge #97. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't touch docs (so no need for approval I think) but lgtm
needs a travis bump @amotl [edit: it needs travis removed from the branch protections or the check will always block the PR] |
4b2d0d2
to
35926d2
Compare
Also, add testing for PHP 7.4.
35926d2
to
36f7ddd
Compare
Hi there,
this patch removes Travis CI and adds GitHub Actions instead. This CI setup is really fast.
With kind regards,
Andreas.