Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve margins #248

Merged
merged 5 commits into from
May 25, 2021
Merged

Improve margins #248

merged 5 commits into from
May 25, 2021

Conversation

amotl
Copy link
Member

@amotl amotl commented Apr 9, 2021

Hi,

because the CSS class "section" is being used by Sphinx itself to render content sections, it should not be used for general layout aspects.

Thus, this patch introduces a separate class w-canvas as an umbrella for the whole content and removes the coupling of the former w-section / section pairing for this very purpose.

With kind regards,
Andreas.

@amotl amotl requested review from nomicode, msbt, proddata and a team April 9, 2021 12:05
Copy link
Member

@proddata proddata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msbt
Copy link
Collaborator

msbt commented Apr 12, 2021

@amotl I've added the mobile margin and the one for images, can you check if it still looks good on your devices?

@msbt
Copy link
Collaborator

msbt commented Apr 12, 2021

uh ok, let me revisit those changes, there's another .section class I've missed :s

@msbt
Copy link
Collaborator

msbt commented Apr 12, 2021

reverted my changes and only pushed the one that actually fixed something, the mobile menu margin-top

@amotl
Copy link
Member Author

amotl commented Apr 12, 2021

Thank you Matthias. So, you already verified that this patch doesn't break anything on the visual level - both on Desktop and Mobile?

@msbt
Copy link
Collaborator

msbt commented Apr 12, 2021

@amotl, yes - at least what I could check with the demo template, the one thing that wasn't working as intended got fixed. We could build a beta release and push it to a single docs repo to see how it behaves in a live environment, @norosa did that with several bigger updates

@proddata
Copy link
Member

maybe we should add some examples in the demo template.

Those whitespaces just look terrible:

image
https://crate.io/docs/crate/tutorials/en/latest/install.html#red-hat-or-centos

@msbt
Copy link
Collaborator

msbt commented Apr 12, 2021

@proddata if you could show me some more examples of elements that have too much space before/after (and also tell me how big the space is supposed to be), we could fix it with this PR

@msbt
Copy link
Collaborator

msbt commented Apr 12, 2021

this is how it would look like if we used margin-bottom: 32px; instead of 64px:

grafik

@amotl amotl marked this pull request as draft April 13, 2021 16:37
@proddata
Copy link
Member

proddata commented Apr 15, 2021

btw ... I think making the h4-headings a bit darker would improve the readability quite a bit.


if we want to go totally crazy, we could rework the code-boxes / syntax highlighting 😬
image

@msbt
Copy link
Collaborator

msbt commented Apr 19, 2021

@belringer
Copy link

belringer commented Apr 19, 2021

@msbt I suggest color #000000 and additionally font-weight: bold;

amotl and others added 5 commits May 25, 2021 13:11
Because the "section" class is being used by Sphinx itself to render
content sections, it should not be used for general layout aspects.

Thus, introduce a separate class "w-canvas" as an umbrella for the
whole content.
missed the mobile margin-top and margin-bottom for images, please check if this still works @amotl

maybe we can add some sample image to the docs test-template to have that element there as well @norosa
fix margin top on mobile menu
@amotl amotl marked this pull request as ready for review May 25, 2021 14:28
@amotl amotl requested a review from msbt May 25, 2021 14:28
@amotl amotl merged commit 6b33841 into master May 25, 2021
@amotl amotl deleted the amo/adjust-layout branch May 25, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants