-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve margins #248
Improve margins #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@amotl I've added the mobile margin and the one for images, can you check if it still looks good on your devices? |
uh ok, let me revisit those changes, there's another .section class I've missed :s |
reverted my changes and only pushed the one that actually fixed something, the mobile menu margin-top |
Thank you Matthias. So, you already verified that this patch doesn't break anything on the visual level - both on Desktop and Mobile? |
@amotl, yes - at least what I could check with the demo template, the one thing that wasn't working as intended got fixed. We could build a beta release and push it to a single docs repo to see how it behaves in a live environment, @norosa did that with several bigger updates |
maybe we should add some examples in the demo template. Those whitespaces just look terrible:
|
@proddata if you could show me some more examples of elements that have too much space before/after (and also tell me how big the space is supposed to be), we could fix it with this PR |
@belringer what colors do you suggest for h4? https://crate.io/docs/crate/tutorials/en/latest/install.html#red-hat-or-centos |
@msbt I suggest color |
aa92b07
to
493575b
Compare
Because the "section" class is being used by Sphinx itself to render content sections, it should not be used for general layout aspects. Thus, introduce a separate class "w-canvas" as an umbrella for the whole content.
missed the mobile margin-top and margin-bottom for images, please check if this still works @amotl maybe we can add some sample image to the docs test-template to have that element there as well @norosa
This reverts commit 41f154d.
fix margin top on mobile menu
Hi,
because the CSS class "
section
" is being used by Sphinx itself to render content sections, it should not be used for general layout aspects.Thus, this patch introduces a separate class
w-canvas
as an umbrella for the whole content and removes the coupling of the formerw-section
/section
pairing for this very purpose.With kind regards,
Andreas.