Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extension "sphinxext.opengraph" #269

Merged
merged 1 commit into from
May 26, 2021
Merged

Add extension "sphinxext.opengraph" #269

merged 1 commit into from
May 26, 2021

Conversation

amotl
Copy link
Member

@amotl amotl commented May 25, 2021 •
edited
Loading

Hi there,

this patch adds and activates the Sphinx extension sphinxext-opengraph to generate OpenGraph metadata (https://ogp.me/).

  <meta property="og:title" content="Different kinds of diagrams" />
  <meta property="og:type" content="website" />
  <meta property="og:url" content="https://crate.io/diagrams.html" />
  <meta property="og:site_name" content="Crate.io documentation" />
  <meta property="og:description" content="PlantUML:" />
  <meta property="og:image" content="https://user-images.githubusercontent.com/453543/119536319-3c9ca480-bd89-11eb-908d-3da78e55f17b.png" />

With kind regards,
Andreas.

@amotl amotl mentioned this pull request May 25, 2021
Closed
@amotl amotl force-pushed the amo/plantuml branch 2 times, most recently from d27fbe0 to 4311ea9 Compare May 25, 2021 17:08
@amotl amotl force-pushed the amo/opengraph branch 2 times, most recently from 758df02 to 36b03cb Compare May 26, 2021 10:08
@amotl amotl force-pushed the amo/plantuml branch 2 times, most recently from 029d0f5 to 4e17245 Compare May 26, 2021 10:28
msbt
msbt approved these changes May 26, 2021
View reviewed changes
Copy link
Collaborator

@msbt msbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@amotl amotl force-pushed the amo/plantuml branch 2 times, most recently from dcb9d3f to e0c0012 Compare May 26, 2021 10:54
Base automatically changed from amo/plantuml to master May 26, 2021 11:02
@amotl amotl merged commit 9278d71 into master May 26, 2021
@amotl amotl deleted the amo/opengraph branch May 26, 2021 11:14
@amotl amotl mentioned this pull request May 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msbt msbt msbt approved these changes

@nomicode nomicode Awaiting requested review from nomicode

@matthijskrul matthijskrul Awaiting requested review from matthijskrul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amotl @msbt