This repository has been archived by the owner on Apr 8, 2024. It is now read-only.
Hints to overload protection and ANALYZE command #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
reviewed
Nov 15, 2023
amotl
reviewed
Nov 15, 2023
docs/performance/inserts/tuning.rst
Outdated
| .. _refresh_interval: https://crate.io/docs/crate/reference/en/latest/sql/reference/create_table.html#refresh-interval | ||
| .. _Solid-State Drives: https://en.wikipedia.org/wiki/Solid-state_drive | ||
| .. _surrogate primary key: https://en.wikipedia.org/wiki/Surrogate_key | ||
| .. _system column: https://crate.io/docs/crate/reference/en/latest/sql/administration/system_columns.html | ||
| .. _translog.durability: https://crate.io/docs/crate/reference/en/latest/sql/reference/create_table.html#translog-durability | ||
| .. _turning column indexes off: https://crate.io/docs/crate/reference/en/latest/sql/ddl/indices_full_search.html#disable-indexing | ||
| :: _Overload Protection: https://cratedb.com/docs/crate/reference/en/latest/config/cluster.html#overload-protection |
There was a problem hiding this comment.
There is a better way to link to other Spinx documentation, like, in this case:
:ref:`crate-reference:overload_protection`
There was a problem hiding this comment.
amotl
reviewed
Nov 15, 2023
amotl
reviewed
Nov 15, 2023
amotl
reviewed
Nov 15, 2023
|
Build still seems to fail due to warnings and broken links (r-project.org seems to be down at the moment?) WARNING: myst-parser 0.12.10 does not provide the extra 'linkify' cc: @amotl |
amotl
force-pushed
the
ckurze/doc-insert-performance
branch
from
708efcb
to
4e0c158
Compare
amotl
approved these changes
Nov 16, 2023
amotl
reviewed
Nov 16, 2023
| @@ -307,3 +311,4 @@ throughput of your cluster with different setups and under different loads. | |||
| .. _translog.durability: https://crate.io/docs/crate/reference/en/latest/sql/reference/create_table.html#translog-durability | |||
| .. _UNNEST reference documentation: https://crate.io/docs/crate/reference/en/latest/sql/statements/insert.html?highlight=unnest#description | |||
| .. _UNNEST: https://crate.io/docs/crate/reference/en/latest/sql/table_functions.html#unnest-array-array | |||
| .. _Overload Protection: https://cratedb.com/docs/crate/reference/en/latest/config/cluster.html#overload-protection | |||
There was a problem hiding this comment.
JFYI: We usually sort those alphabetically, instead of just adding new links at the bottom.
amotl
reviewed
Nov 16, 2023
Comment on lines
+103
to
+116
| Overload Protection | ||
| ------------------- | ||
|
|
||
| The `Overload Protection`_ settings control how many resources operations like | ||
| ``INSERT INTO FROM QUERY`` or ``COPY`` can use. | ||
|
|
||
| The default values serve as a starting point for an algorithm that dynamically | ||
| adapts the effective concurrency limit based on the round-trip time of requests. | ||
| Whenever one of these settings is updated, the previously calculated effective | ||
| concurrency is reset. | ||
|
|
||
| Please update the settings accordingly, especially if you are benchmarking insert | ||
| performance. | ||
|
|
There was a problem hiding this comment.
A few trailing spaces sneaked in here. Can I humbly ask you to configure your editor to strip those, or take extra care when committing?
|
Hi. I've forward-ported your patch to the new instance of this documentation, also addressing a few suggestions right away. Thank you again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
Checklist