Suspending/resuming a cluster takes down / creates the load balancer #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SStorm
reviewed
Apr 5, 2023
juanpardo
force-pushed
the
jp/load-balancer-regeneration
branch
from
1958a5e
to
bfcdd09
Compare
juanpardo
requested review from
plaharanne,
tomach,
WalBeh and
Taliik
as code owners
SStorm
approved these changes
Apr 17, 2023
| @@ -982,22 +985,27 @@ async def create_services( | |||
| ) -> None: | |||
| async with ApiClient() as api_client: | |||
| core = CoreV1Api(api_client) | |||
|
|
|||
| # Create the load balancer service | |||
| svc = get_data_service( | |||
There was a problem hiding this comment.
You probably no longer need to extract this into a variable?
…he load balancer.
…letes the load balancer.
… now deletes the load balancer.
…cluster now deletes the load balancer.
…ding a cluster now deletes the load balancer.
… Suspending a cluster now deletes the load balancer.
… fixup! Suspending a cluster now deletes the load balancer.
… fixup! fixup! Suspending a cluster now deletes the load balancer.
… fixup! fixup! fixup! Suspending a cluster now deletes the load balancer.
… fixup! fixup! fixup! fixup! Suspending a cluster now deletes the load balancer.
… fixup! fixup! fixup! fixup! fixup! Suspending a cluster now deletes the load balancer.
… fixup! fixup! fixup! fixup! fixup! fixup! Suspending a cluster now deletes the load balancer.
juanpardo
force-pushed
the
jp/load-balancer-regeneration
branch
from
ebab9b7
to
0ee9e28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Checklist
CHANGES.rst