Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update list of supported PHP versions #152

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Update list of supported PHP versions #152

merged 1 commit into from
Jan 10, 2024

Conversation

hlcianfagna
Copy link
Contributor

https://www.php.net/supported-versions.php

Summary of the changes / Why this is an improvement

Checklist

  • CLA is signed

@hlcianfagna hlcianfagna marked this pull request as ready for review January 9, 2024 12:35
@hlcianfagna hlcianfagna requested a review from amotl January 9, 2024 12:35
@amotl
Copy link
Member

amotl commented Jan 9, 2024 •
edited
Loading

Hi, and thanks for the patch.

Regarding the removal of PHP 7.x, may I ask if something was breaking in this regard, so that it needed a fix? I mean, the driver still supports PHP 7.x regardless whether it may be outdated or not. So, as long as the driver supports it, why not keep the corresponding CI matrix slots?

On another note, may I ask you to also update composer.json at this spot, by adding |^8.3?

amotl
amotl reviewed Jan 9, 2024
View reviewed changes
.github/workflows/tests.yml Outdated Show resolved Hide resolved
amotl
amotl reviewed Jan 9, 2024
View reviewed changes
.github/workflows/tests.yml Outdated Show resolved Hide resolved
@hlcianfagna
Copy link
Contributor Author

Hi @amotl , the reason why I was doing this change was that tests for the older versions were failing for #151 , but it seems you already unlocked that somehow? I am happy to keep the older versions or do just the oldest and newest is that is the standard approach you use for other projects.

@amotl
Copy link
Member

amotl commented Jan 10, 2024 •
edited
Loading

Yeah, GH-151 was just failing because of some intermittent fluke, apparently. Feel free to adjust the patch how you like it. Easiest variant is probably to just add PHP 8.3 without further ado, just not removing any other items.

@hlcianfagna @amotl
Update list of supported PHP versions
172cf6e 
https://www.php.net/supported-versions.php

Add PHP 8.3 to composer.json

Add PHP 8.3 without removing older versions

Co-Authored-By: Andreas Motl <andreas.motl@crate.io>
@hlcianfagna
Copy link
Contributor Author

retest this please

@amotl
Copy link
Member

amotl commented Jan 10, 2024

Thanks. Let me know if this will need a release.

@hlcianfagna hlcianfagna merged commit 4145fe7 into main Jan 10, 2024
13 checks passed
@hlcianfagna hlcianfagna deleted the hlcianfagna/updateghactions branch January 10, 2024 15:10
@amotl
Copy link
Member

amotl commented Jan 11, 2024 •
edited
Loading

Will you also submit a corresponding improvement to the DBAL/Doctrine adapter?

@amotl amotl mentioned this pull request Jan 11, 2024
Closed
@amotl amotl mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotl amotl amotl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hlcianfagna @amotl