-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correctly attach error_trace from server to raised exceptions #90
Conversation
url_params = {} | ||
if error_trace: | ||
if self.error_trace: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why making an instance variable if nowhere else used?
@@ -337,9 +339,10 @@ def _raise_for_status(self, response): | |||
).startswith("application/json"): | |||
data = json.loads(six.text_type(response.data, 'utf-8')) | |||
error = data.get('error', {}) | |||
error_trace = data.get('error_trace', {}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you use None as default value for error_trace in the exception constructor I would also use None as default here
ack |
squash & merge pls |
correctly attach error_trace from server to raised exceptions
No description provided.