Fix BWC issue with aggregation func resolving #10557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd add a crate-qa test for aggregations instead of adding a related test here as a follow up. |
mfussenegger
approved these changes
Sep 18, 2020
seut
added
the
ready-to-merge
seut
added a commit
to crate/crate-qa
that referenced
this pull request
Sep 18, 2020
We had a regression on BWC for aggregations which have a different intermediate input data type than the initial argument type causing aggregation streamed from a 4.1 node to a 4.2 node to not being resolvable. This adds the related statement to the rolling upgrade test to ensure that it will correctly work on mixed version clusters. Relates crate/crate#10557.
Aggregation functions have partial intermediate states which cannot be used for aggregation full qualified resolving when a `Signature` is not available when the function is streamed by nodes < 4.2. Thus the registered argument types of the deprecated `FunctionInfo` must be used for this fallback full qualified resolving and not the actual input types.
seut
added a commit
to crate/crate-qa
that referenced
this pull request
Sep 25, 2020
We had a regression on BWC for aggregations which have a different intermediate input data type than the initial argument type causing aggregation streamed from a 4.1 node to a 4.2 node to not being resolvable. This adds the related statement to the rolling upgrade test to ensure that it will correctly work on mixed version clusters. Relates crate/crate#10557.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggregation functions have partial intermediate states which cannot be used for aggregation full qualified resolving when a
Signatureis not available when the function is streamed by nodes < 4.2.Thus the registered argument types of the deprecated
FunctionInfomust be used for this fallback full qualified resolving and not the actual input types.Relates #10415.