Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate aggregation examples at the "Selecting data" docs #11268

Merged
merged 2 commits into from Apr 14, 2021
Merged

Remove duplicate aggregation examples at the "Selecting data" docs #11268

merged 2 commits into from Apr 14, 2021

Conversation

seut
Copy link
Member

@seut seut commented Apr 14, 2021 •
edited

Available aggergations are documented in detail at the dedicated
aggregations.rst documentation. So 1 example inside the
general "Selecting data" section should be enough.

Closes #11243.

Checklist

  • Added an entry in CHANGES.txt for user facing changes
  • Updated documentation & sql_features table for user facing changes
  • Touched code is covered by tests
  • CLA is signed
  • This does not contain breaking changes, or if it does:
    • It is released within a major release
    • It is recorded in CHANGES.txt
    • It was marked as deprecated in an earlier release if possible
    • You've thought about the consequences and other components are adapted
      (E.g. AdminUI)

@seut
Remove duplicate aggregation examples at the "Selecting data" docs
2274630 
Available aggergations are documented in detail at the dedicated
`aggregations.rst` documentation. So 1 example inside the
general "Selecting data" section shopuld be enough.

Closes #11243.
@seut seut requested review from a team, mfussenegger and nomicode and removed request for a team April 14, 2021 10:14
@seut seut added the ready-to-merge Let Mergify merge the PR once approved and checks pass label Apr 14, 2021
@mergify mergify bot merged commit 9ddd28d into master Apr 14, 2021
@mergify mergify bot deleted the s/docs-remove-aggs-duplicates branch April 14, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfussenegger mfussenegger mfussenegger approved these changes

@nomicode nomicode Awaiting requested review from nomicode

Assignees
No one assigned
Labels
ready-to-merge Let Mergify merge the PR once approved and checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why do we document aggregations twice?
2 participants
@seut @mfussenegger