Prune columns of scalar sub-queries #13895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PRs: #13668 #13712 Added columns used in the where clause to the select list to make them available for parent operators. The idea was that they'd get pruned if not required, but we didn't prune columns of a scalar-subquery. This led to a ~5%(?) performance decrease on some of our benchmarks (`in_subquery.toml`).
mfussenegger
force-pushed
the
j/prune-subquery
branch
from
63bd781
to
b2ebdc7
Compare
mfussenegger
added
the
ready-to-merge
4 tasks
This was referenced May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PRs:
#13668
#13712
Added columns used in the where clause to the select list to make them
available for parent operators.
The idea was that they'd get pruned if not required, but we didn't
prune columns of a scalar-subquery. This led to a ~5%(?) performance
decrease on some of our benchmarks (
in_subquery.toml).