Ensure that CLUSTERED BY column is not NULL on insert-from-subquery #14364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaurzhanSakhariev
force-pushed
the
b/clustered-by-check
branch
from
af08c92
to
791a92b
Compare
server/src/test/java/io/crate/integrationtests/InsertIntoIntegrationTest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/crate/execution/engine/indexing/GroupRowsByShard.java
Show resolved
Hide resolved
BaurzhanSakhariev
force-pushed
the
b/clustered-by-check
branch
from
6f1e382
to
b7bedb0
Compare
seut
reviewed
Jul 6, 2023
server/src/test/java/io/crate/integrationtests/InsertIntoIntegrationTest.java
Outdated
Show resolved
Hide resolved
BaurzhanSakhariev
force-pushed
the
b/clustered-by-check
branch
from
ab43214
to
1f8a441
Compare
BaurzhanSakhariev
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate fix for one of the bugs reported in https://github.com/crate/crate/pull/14317/files#diff-6b4ff31a02425d333cc54423875ca7ab94432d3399bd0d6b45797763cbb5dcd7R247-R259
Since we are doing this check before creating a partition, even if we have a
partitioned bycolumn along withclustered byone, partition won't be created.Same issue on 5.2.8, not a regression in 5.3