Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of query conditions in delete/update with WHERE doc-keys #15293

Merged
merged 3 commits into from Jan 8, 2024

Conversation

mfussenegger
Copy link
Member

#10708 changed the EqualityExtractor
to allow in-exact matches, this change wasn't reflected by the update
and delete planner, until #14361
tried to fix it, but it didn't account for AND clauses without
references.

#10708 changed the EqualityExtractor
to allow in-exact matches, this change wasn't reflected by the update
and delete planner, until #14361
tried to fix it, but it didn't account for AND clauses without
references.
Copy link
Contributor

@jeeminso jeeminso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mfussenegger mfussenegger added the ready-to-merge Let Mergify merge the PR once approved and checks pass label Jan 8, 2024
@mergify mergify bot merged commit 8251d26 into master Jan 8, 2024
16 checks passed
@mergify mergify bot deleted the j/update-by-id branch January 8, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Let Mergify merge the PR once approved and checks pass v/5.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants