Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend 3.0.7 notes with notice about changes to CREATE REPOSITORY #7736

Merged
merged 1 commit into from
Oct 8, 2018

Conversation

autophagy
Copy link
Contributor

In 3.0.0, a breaking change was introduced that removed the 'region'
setting from the accepted parameters of the CREATE REPOSITORY query,
instead opting to infer the region from the endpoint parameter.

However, between 3.0.0 and 3.0.6, this 'region' setting was accepted as
valid syntax, meaning that CREATE REPOSITORY queries that should not
have been accepted, were. This was fixed in 3.0.7 with 37a4fee

This commit adds a notice to the release notes of 3.0.7, warning that
the behaviour of the CREATE REPOSITORY query may break between 3.0.6 and
3.0.7.

@autophagy autophagy force-pushed the mika/breaking--ammendment-3.0.7 branch from 4a17d8d to 6413cb5 Compare October 5, 2018 13:51
@autophagy autophagy changed the base branch from 3.0 to master October 5, 2018 13:51
@autophagy autophagy force-pushed the mika/breaking--ammendment-3.0.7 branch from 6413cb5 to 4eae830 Compare October 5, 2018 14:05
Copy link
Contributor

@nomicode nomicode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed some edits. if you like them, you can squash them in :)

In 3.0.0, a breaking change was introduced that removed the 'region'
setting from the accepted parameters of the CREATE REPOSITORY query,
instead opting to infer the region from the endpoint parameter.

However, between 3.0.0 and 3.0.6, this 'region' setting was accepted as
valid syntax, meaning that CREATE REPOSITORY queries that should not
have been accepted, were. This was fixed in 3.0.7 with 37a4fee

This commit adds a notice to the release notes of 3.0.7, warning that
the behaviour of the CREATE REPOSITORY query may break between 3.0.6 and
3.0.7.
@autophagy autophagy force-pushed the mika/breaking--ammendment-3.0.7 branch from 3684314 to 1eeec32 Compare October 5, 2018 14:19
@autophagy autophagy added the ready-to-merge Let Mergify merge the PR once approved and checks pass label Oct 8, 2018
@mergify mergify bot merged commit d497332 into master Oct 8, 2018
@nomicode nomicode deleted the mika/breaking--ammendment-3.0.7 branch October 8, 2018 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Let Mergify merge the PR once approved and checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants