New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild version map when opening internal engine #9394
Conversation
@marregui Any reasons to not backport the related test as well? https://github.com/elastic/elasticsearch/pull/43202/files#diff-8a78dedbc25426973364f21bdc81c27aR5946 |
That test uses a class that was renamed from
I thought that at that point I would stop and reconsider. |
@marregui So why not backport elastic/elasticsearch#41661 first? |
Thank you, I thought about it, and that is partially the reason I stopped, to get feedback. PR #9399 |
With this change, we will verify the consistency of version and source (besides id, seq_no, and term) of live documents between shard copies at the end of disruption tests. Port of elastic/elasticsearch#41614 Required by #9394
With this change, we will verify the consistency of version and source (besides id, seq_no, and term) of live documents between shard copies at the end of disruption tests. Port of elastic/elasticsearch#41614 Required by #9394
With this change, we will verify the consistency of version and source (besides id, seq_no, and term) of live documents between shard copies at the end of disruption tests. Port of elastic/elasticsearch#41614 Required by #9394 (cherry picked from commit ddba3be)
With this change, we will verify the consistency of version and source (besides id, seq_no, and term) of live documents between shard copies at the end of disruption tests. Port of elastic/elasticsearch#41614 Required by #9394 (cherry picked from commit ddba3be)
dfda10b
to
bf6e5e4
Compare
I believe I need to port elastic/elasticsearch#41161 as well, test
this code is removed in PR41161 |
@marregui Yes please backport elastic/elasticsearch#41161 upfront as well. |
and that one requires this one: elastic/elasticsearch#39571 it is very simple. |
With this change, we will rebuild the live version map and local checkpoint using documents (including soft-deleted) from the safe commit when opening an internal engine. This allows us to safely prune away _id of all soft-deleted documents as the version map is always in-sync with Lucene index. Relates #40741 (elastic/elasticsearch#40741) Supersedes #42979 (elastic/elasticsearch#42979) Port of elastic/elasticsearch#43202
bf6e5e4
to
ec216f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
With this change, we will rebuild the live version map and local checkpoint using
documents (including soft-deleted) from the safe commit when opening an internal
engine. This allows us to safely prune away _id of all soft-deleted documents as
the version map is always in-sync with Lucene index.
Relates #40741 (elastic/elasticsearch#40741)
Supersedes #42979 (elastic/elasticsearch#42979)
Port of elastic/elasticsearch#43202