Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testcontainers for Java: Add examples for init scripts and function #59

Merged
merged 3 commits into from Apr 20, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented Apr 17, 2023

Hi. This is a followup to GH-54, ticking a few more boxes of GH-55.

@amotl amotl requested a review from matriv April 17, 2023 19:34
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Pushed the fix.
For the DDL there is a null result set returned so internally the driver returns false.

Copy link
Member Author

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the failing test case, and for your suggestions.

testing/testcontainers/java/README.rst Outdated Show resolved Hide resolved
@amotl amotl force-pushed the amo/testing-testcontainers-java-2 branch from 3455e77 to 3af1ca4 Compare April 20, 2023 12:19
@amotl amotl merged commit 13543cd into main Apr 20, 2023
1 check passed
@amotl amotl deleted the amo/testing-testcontainers-java-2 branch April 20, 2023 12:22
@amotl amotl mentioned this pull request Apr 20, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants