-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist results to CrateDB for tracking_merlion.py
#20
Conversation
895798c
to
7b2e523
Compare
Codecov ReportAll modified lines are covered by tests ✅ see 4 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
7b2e523
to
f5d6439
Compare
eb70737
to
380d476
Compare
""" | ||
), | ||
) | ||
assert anomalies_generated.rowcount >= 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting varying results here. Generates three anomalies locally, but only one here on GitHub. Not sure why, but it shouldn't matter for testing the code path of getting the anomalies saved into the database.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's investigate on behalf of a subsequent iteration.
There is a test failure for |
|
""" | ||
), | ||
) | ||
assert anomalies_generated.rowcount >= 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's investigate on behalf of a subsequent iteration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
6b1a57b
to
2973a61
Compare
Store known anomalies in a database table, instead of hard-coding them in Python. Then, save detected anomalies alongside in that table.