Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist results to CrateDB for tracking_merlion.py #20

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

hammerhead
Copy link
Member

@hammerhead hammerhead commented Sep 14, 2023

Store known anomalies in a database table, instead of hard-coding them in Python. Then, save detected anomalies alongside in that table.

@hammerhead hammerhead force-pushed the hammerhead/persist-results branch 4 times, most recently from 895798c to 7b2e523 Compare September 14, 2023 14:57
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

All modified lines are covered by tests ✅

see 4 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

examples/tracking_merlion.py Outdated Show resolved Hide resolved
examples/tracking_merlion.py Outdated Show resolved Hide resolved
@hammerhead hammerhead force-pushed the hammerhead/persist-results branch 4 times, most recently from eb70737 to 380d476 Compare October 17, 2023 06:22
"""
),
)
assert anomalies_generated.rowcount >= 1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting varying results here. Generates three anomalies locally, but only one here on GitHub. Not sure why, but it shouldn't matter for testing the code path of getting the anomalies saved into the database.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's investigate on behalf of a subsequent iteration.

@hammerhead hammerhead marked this pull request as ready for review October 17, 2023 06:52
@hammerhead
Copy link
Member Author

There is a test failure for tests.test_tracking.TestSqlAlchemyStore testMethod=test_log_inputs_with_duplicates_in_single_request that also appears after a retry. Sounds unrelated to the example change? Do you have an idea where that comes from, @amotl?

@hammerhead hammerhead requested a review from amotl October 17, 2023 06:57
@amotl
Copy link
Member

amotl commented Oct 17, 2023

test_log_inputs_with_duplicates_in_single_request is flaky, see GH-11. It succeeded when retrying another time.

tests/test_examples.py Outdated Show resolved Hide resolved
tests/test_examples.py Outdated Show resolved Hide resolved
tests/test_examples.py Outdated Show resolved Hide resolved
"""
),
)
assert anomalies_generated.rowcount >= 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's investigate on behalf of a subsequent iteration.

Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Co-authored-by: Andreas Motl <andreas.motl@crate.io>
@amotl amotl merged commit 9d7748e into main Oct 17, 2023
2 of 3 checks passed
@amotl amotl deleted the hammerhead/persist-results branch October 17, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants