Make sure vault-produced escape hatches aren't erased #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amalloy
force-pushed
the
escape-stair-fixup
branch
from
bc27421
to
e7be584
Compare
> placed at branch ends, and < at branch entrances, used to be deleted because those features aren't legal in those places. This could lead to players being trapped, eg if an 'island' vault with a hatch down generated on Lair:8. Now, we replace any vault-mandated escape hatches with whatever escape feature is appropriate for the current branch/floor.
amalloy
force-pushed
the
escape-stair-fixup
branch
from
e7be584
to
e34a803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
>placed at branch ends, and<at branch entrances, used to be deletedbecause those features aren't legal in those places. This could lead to
players being trapped, eg if an 'island' vault with a hatch down
generated on Lair:8. Now, we replace any vault-mandated escape hatches
with whatever escape feature is appropriate for the current branch/floor.
Could use some review, particularly from @neilmoore, who suggested the implementation some time ago but I never got around to it.