-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Swamp endvault with Fedhas and Yred theming. #961
Conversation
Thanks for the submission. This is a reasonable idea for an end vault, although it does share theme with the other undead map. I think it's interesting to try some yred-themed monster "crossover" from Crypt like you've done, although getting a good set of monsters for that might take some work. I can leave some quick comments now and take a closer look later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a first pass over this. There are other issues, but I'll save anything else for when I have time to look at this in more detail.
ccc........cccE2E3333EE2Eccc | ||
ccP....o...PccEE53335333Eccc | ||
cct6..P_P.6tcccE3333q335Eccc | ||
cc6.P.7P7.P6cccE3333D333Eccc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This area in general lacks trees for druids to really do their thing. You might want to randomly scatter some trees throughout the open space so that they can awaken them. Could expand the space a little so that there is a bit more room for trees, bu there's already enough to put at least a few there.
You can make a smattering of said trees used the "dead tree" tile as part of the Yred vs. Fedhas thing, if you wish, but that's only if you like the flavor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I scattered a few throughout, including some deliberate dead and living trees spreading toward the other lobe. It should be tricky at this point to get a tile away from all trees without going deep into the lobes unless you luck out and get a wall-heavy front section.
a6018e6
to
825e2be
Compare
Squashed the commits into one, and reworked the monster list (especially on the Yred side.) Now has a pair of vampire knights with an assortment of yred gifts and undead hydras for backup, and a 1:11 chance of having an undead lerny. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool idea. I'm not much of an expert on vault design / balance, so I'll leave that for gammafunk, but I have a couple internal-cleanup things to suggest.
ORIENT: float | ||
TAGS: no_rotate | ||
MONS: swamp dragon / swamp drake / hydra | ||
MONS: freezing wraith / flayed ghost / phantasmal warrior / ghoul |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whitespace is off here.
KMONS: p = plant | ||
KMONS: ' = oklob plant | ||
KMONS: q = vampire knight | ||
: if crawl.one_chance_in(11) then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions here. This vault will occur in like 7% of Swamp:$ instances, given how many other Swamp:$ vaults there are. Placing the undead Learnaean hydra in just 9% of those will make it a pretty rare find. I imagine that's intentional, I'm just a little surprised you wanted it to be so rare. Do you think it's too difficult to place 100% of the time? Do you want it to be so rare as to be very exciting when a player runs into it?
Second, I wouldn't do this with a one_chance_in. Why not just do it with a weighted MONS, where the sum of weights for undead lernaean hydrae is much less than the total weight?
MONS: the lernaean hydra skeleton / spectral the lernaean hydra / ... / spectral hydra w:100 / hydra simulacrum w:100
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For both of these, I was copying swamp_basic_johnstein; now that I look more carefully, I see that one is an outlier. I'm pretty sure undead lerny is significantly easier than non-undead-lerny; low MR, and the only high damage one is also slow.
I'll change this.
MONS: patrolling thorn hunter / patrolling shambling mangrove | ||
MONS: patrolling spriggan druid god:fedhas | ||
KITEM: O = decaying rune of Zot | ||
KFEAT: _ = altar_fedhas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_
and D
are symbols that don't have any obvious similarity or mnemonic. What about F
and Y
to label each lobe, or _
and -
to make them both look altar-ish?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough
825e2be
to
3e27608
Compare
All right, I made those changes. I doubt gammafunk is interested in reviewing this any further; is there anyone else on the dev team that typically reviews vault game design stuff? |
Includes an undead lerny (which should generally be weaker than a living lerny; the only one that does more damage is simulacrum which is 8 speed and low MR.) Equal chance of the rune being in each lobe. Yred lobe has 2 vampire knight and assorted yred gifts and some undead hydras/drakes. Fedhas lobe has several thorn hunters/shambling mangroves, 2 spriggan druids, and a handful of oklobs. The antechamber is watery, and populated by a bunch of swamp drakes/dragons and an undead Lerny.
3e27608
to
c645954
Compare
Merged as 8ac0393, after some small fixes to commit message and comments. Thanks for the vault! |
No description provided.