-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stacking of tiddlers on the left side doesn't reveal tiddlers title unlike one the right side [Safari browser] #13
Comments
Thanks for the report. Could you please help me with the reproduction of this issue? The tiddler title should be present even when you scroll down, but it may be missing in following cases:
Could those be causing the issue you have? Or can you describe some steps to reproduce? |
|
"When multiple tiddlers are opened, stacking of tiddlers on the left side doesn't reveal the tiddlers title unlike on the right side" Few points which I noted which can even improve Krystal are:
|
Unfortunately, I can't test it in Safari.
That's a good idea.
I'm afraid by implementing this it'll start to be a bit over-complicated. If anything, by clicking on the link in the maximised state it returns back to the default state is something I can imagine. |
Keyboard shortcut for going into and coming out of the maximised state of a tiddler will be very handy. "Clicking on the link in a tiddler in the maximised state returns back to the default state" - Providing this option also will definitely enhance the workflow. I also I want a keyboard shortcut to not close tiddlers to the right. Currently if we open multiple tiddler from recents or if we open multiple links from a single tiddler, the second opened tiddler will replace the first opened tiddler and so on. But if you can configure it like this it will be better - just 'clicking' on the links will behave normally, but if we 'shift-click' on the link, the tiddlers to the right should not close. I know that there is an option to configure it in the settings. But it affects the workflow if we have to go to settings every time to change it. Only problem now remaining will be when 4 or more tiddlers are open simultaneously, it will be difficult to see and compare two non-adjacent tiddlers. For example, if I want to see 2nd and 5th tiddler simultaneously, its not possible in the current set up. But this is not a big problem. I have encountered such situation once in a while only. Can you think of any workaround for this? Also, do you find dropdown option for the contents in the the topbar useful? I have found such a setup in mentat story river (https://thesherwood.github.io/Mentat/) and at http://tongerner.tiddlyspot.com. I am very happy using Krystal and I have built my personal tiddlywiki based on Krystal. |
Let's discuss all the other things in a separate issues. |
If someone is able to investigate this issue (stacking in the left side) in Safari browser, let me know. |
This issue can be reproduced on Firefox 84. I did not test it with Safari, but I believe the behaviour on Firefox is similar with Safari --- The stacked tiddlers' title are not shown (blank). I investigate the class name and find out that the class name I debug the code in ...,
padding: "31px"
paddingBlock: "31px"
paddingBlockEnd: "31px"
paddingBlockStart: "31px"
paddingBottom: "31px"
paddingInline: "31px"
paddingInlineEnd: "31px"
paddingInlineStart: "31px"
paddingLeft: "31px"
paddingRight: "31px"
paddingTop: "31px"
... And below are the returned values on Firefox: ...,
padding: ""
"padding-block": ""
"padding-block-end": "31px"
"padding-block-start": "31px"
"padding-bottom": "31px"
"padding-inline": ""
"padding-inline-end": "31px"
"padding-inline-start": "31px"
"padding-left": "31px"
"padding-right": "31px"
"padding-top": "31px"
paddingBlock: ""
paddingBlockEnd: "31px"
paddingBlockStart: "31px"
paddingBottom: "31px"
paddingInline: ""
paddingInlineEnd: "31px"
paddingInlineStart: "31px"
paddingLeft: "31px"
paddingRight: "31px"
paddingTop: "31px"
... There is a similar issue here, stating that the padding property only works for Chromium based browser. The problem seems that Firefox treat I attempt to modify the code in This is quite an ad-hoc solution (I guess). Not sure if any better solution to get the padding values from the plugin settings directly. |
It'd be possible to get it from the settings, you are right. Another way would be to get custom CSS property directly (I just learned it's also possible): window.getComputedStyle(tiddlers[0]).getPropertyValue('--tiddler-padding') Your solution works, so let's stick with that :) thanks |
When multiple tiddlers are opened, stacking of tiddlers on the left side doesn't reveal the tiddlers title unlike on the right side.
I am attaching some images for reference.
In the first image, the first two tiddlers on the left side are in focus while the unfocussed tiddlers one the left side are stacked together with their titles revealed.
In the second image, the last two tiddlers on the left side are in focus, while the unfocussed tiddlers on the left side are neither shown as in stack nor their title are revealed.
This third image is showing that one tiddler stacked on the right is not showing its title (third one from the right) because I had scrolled to the bottom of that tiddler before moving to another tiddler.
Can this be corrected?
The text was updated successfully, but these errors were encountered: