-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use docker labels rather than statically defined configs #3
Comments
So, I'd suggest the following labels:
I'd also add to the watch:
docker: true # or a path to the Docker socket
unlabeled-containers: true # also watch unlabeled containers?
stopped-containers: true # also watch stopped containers? If that's fine, I can create a pull request for that. 🙃 |
Hi @moqmar, Thanks for your suggestions! I would prefer to work with fields. This way we could easily serialize to the same struct as the current static configuration:
What do you think? Anyway feel free to open a PR :) |
Hm, I think having both possibilities would be great, so it's possible to "just enable diun" with a single-word-label, but also to directly configure it for more advanced options. I'll try to put something together. :) |
@moqmar Of course, I was just stating all the labels and there will be default values. |
Glad to see this is still progressing in some way. My biggest concern with running containers is that you don't typically see any update notifications anywhere. You can use things like Ouroboros and the other one I've forgotten but that's assuming that all containers are created equal and sadly this is not the case. Sometimes you just use a container because it's the only one reliable enough to deploy. At least being notified will make a big difference. |
@Leopere Done through release 2.0.0 |
Oh, that's very nice thank you! I'm looking forward to plugging this thing into my entire docker stack! |
Referenced feature in #1 and #2
The text was updated successfully, but these errors were encountered: