Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parametrize node id type #17

Closed
crclark opened this issue Feb 18, 2023 · 2 comments
Closed

parametrize node id type #17

crclark opened this issue Feb 18, 2023 · 2 comments

Comments

@crclark
Copy link
Owner

crclark commented Feb 18, 2023

To allow for graphs bigger than max value of u32

@crclark
Copy link
Owner Author

crclark commented Feb 19, 2023

We would need to work around lumol-org/soa-derive#35, so I will delay this work for now.

@crclark
Copy link
Owner Author

crclark commented Jul 9, 2023

It actually makes more sense to shard the data structure rather than allow for huge graphs, because using bigger node id types has a significant impact on memory usage -- the data structure internally is mostly storing many elements of the type of the node id, so doubling its size has a massive impact on memory usage. Real-world usage would want to shard well before the billions-scale that a 32 bit id allows, anyway.

@crclark crclark closed this as not planned Won't fix, can't repro, duplicate, stale Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant