Some valid CRDs are not rendered

[muvaf]

Linking an issue from original repo crossplane-contrib/provider-jet-aws#134

I couldn't immediately find out why. This one for example doesn't have an obvious issue I could spot in its schema.

[AaronME]

Did some basic trouble-shooting. It looks like the schema for AutoScalingGroup includes a field for "tags" which is defined as an "array" and the items schema says it should be an array of "object" types.

However, properties field of this array is set to null, which is breaking the page at

doc/template/doc.html

Line 109 in cb01d9f

let propKeys = Object.keys(props);

Including the relevant "tags" schema below:

"tags":
{
    "ID": "",
    "Schema": "",
    "Ref": null,
    "Description": "",
    "Type": "array",
    "Nullable": false,
    "Format": "",
    "Title": "",
    "Default": null,
    "Maximum": null,
    "ExclusiveMaximum": false,
    "Minimum": null,
    "ExclusiveMinimum": false,
    "MaxLength": null,
    "MinLength": null,
    "Pattern": "",
    "MaxItems": null,
    "MinItems": null,
    "UniqueItems": false,
    "MultipleOf": null,
    "Enum": null,
    "MaxProperties": null,
    "MinProperties": null,
    "Required": null,
    "Items":
    {
        "Schema":
        {
            "ID": "",
            "Schema": "",
            "Ref": null,
            "Description": "",
            "Type": "object",
            "Nullable": false,
            "Format": "",
            "Title": "",
            "Default": null,
            "Maximum": null,
            "ExclusiveMaximum": false,
            "Minimum": null,
            "ExclusiveMinimum": false,
            "MaxLength": null,
            "MinLength": null,
            "Pattern": "",
            "MaxItems": null,
            "MinItems": null,
            "UniqueItems": false,
            "MultipleOf": null,
            "Enum": null,
            "MaxProperties": null,
            "MinProperties": null,
            "Required": null,
            "Items": null,
            "AllOf": null,
            "OneOf": null,
            "AnyOf": null,
            "Not": null,
            "Properties": null,
            "AdditionalProperties":
            {
                "Allows": true,
                "Schema":
                {
                    "ID": "",
                    "Schema": "",
                    "Ref": null,
                    "Description": "",
                    "Type": "string",
                    "Nullable": false,
                    "Format": "",
                    "Title": "",
                    "Default": null,
                    "Maximum": null,
                    "ExclusiveMaximum": false,
                    "Minimum": null,
                    "ExclusiveMinimum": false,
                    "MaxLength": null,
                    "MinLength": null,
                    "Pattern": "",
                    "MaxItems": null,
                    "MinItems": null,
                    "UniqueItems": false,
                    "MultipleOf": null,
                    "Enum": null,
                    "MaxProperties": null,
                    "MinProperties": null,
                    "Required": null,
                    "Items": null,
                    "AllOf": null,
                    "OneOf": null,
                    "AnyOf": null,
                    "Not": null,
                    "Properties": null,
                    "AdditionalProperties": null,
                    "PatternProperties": null,
                    "Dependencies": null,
                    "AdditionalItems": null,
                    "Definitions": null,
                    "ExternalDocs": null,
                    "Example": null,
                    "XPreserveUnknownFields": null,
                    "XEmbeddedResource": false,
                    "XIntOrString": false,
                    "XListMapKeys": null,
                    "XListType": null,
                    "XMapType": null
                }
            },
            "PatternProperties": null,
            "Dependencies": null,
            "AdditionalItems": null,
            "Definitions": null,
            "ExternalDocs": null,
            "Example": null,
            "XPreserveUnknownFields": null,
            "XEmbeddedResource": false,
            "XIntOrString": false,
            "XListMapKeys": null,
            "XListType": null,
            "XMapType": null
        },
        "JSONSchemas": null
    },
    "AllOf": null,
    "OneOf": null,
    "AnyOf": null,
    "Not": null,
    "Properties": null,
    "AdditionalProperties": null,
    "PatternProperties": null,
    "Dependencies": null,
    "AdditionalItems": null,
    "Definitions": null,
    "ExternalDocs": null,
    "Example": null,
    "XPreserveUnknownFields": null,
    "XEmbeddedResource": false,
    "XIntOrString": false,
    "XListMapKeys": null,
    "XListType": null,
    "XMapType": null
},

[AaronME]

This code block assumes that all "object" types have properties:

doc/template/doc.html

Lines 95 to 109 in cb01d9f

	let props = property.Properties || {};
	let type = property.Type;
	if (type === 'array') {
	const itemsSchema = property.Items.Schema;
	if (itemsSchema.Type !== 'object') {
	type = `[]${itemsSchema.Type}`;
	} else {
	console.log({ property, itemsSchema });
	schema = itemsSchema;
	props = itemsSchema.Properties;
	type = `[]object`;
	}
	}
	let propKeys = Object.keys(props);

[AaronME]

@muvaf Could you confirm whether crdsdev needs to accommodate this type of schema or if this might be a bug in the generated type?

[hasheddan]

@AaronME if the k8s api server accepts it then we should be accommodating it here 👍🏻 I'm working on some fixes

[muvaf]

@AaronME thanks for debugging! Seems like that field has the type of []map[string]*string, which might be why.