Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Notifications. #4

Open
jigarfumakiya opened this issue Aug 26, 2021 · 4 comments
Open

[Suggestion] Notifications. #4

jigarfumakiya opened this issue Aug 26, 2021 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jigarfumakiya
Copy link

Hello @Crdzbird
Thanks for the package.
I would like to suggest few features related to notification that make sense. and I would be happy to work on PR.

  1. Show downloaded progress via notification [using flutter_local_notification].
  2. Once the download is completed show the completed download notification
  3. After download clicking on the notification will open that file.

Let me know what you think.
Feedback is welcome.
Thanks

@Crdzbird
Copy link
Owner

Hi @jigarfumakiya sounds amazing the ideas that you are proposing 😄

it can be really helpful and of curse incredible to have those features implemented on the Flowder plugin. If you wanna work on a PR related to those 3 points, please feel free to do it. 👨‍💻

@Crdzbird Crdzbird added enhancement New feature or request good first issue Good for newcomers labels Aug 26, 2021
@jigarfumakiya
Copy link
Author

@Crdzbird Perfect will work on PR.
And let you know.

@jigarfumakiya
Copy link
Author

Hey @Crdzbird

I have started working on the Notification PR.

Just quick question
So after debugging in the code I found out that there is currently an underline issue with resume functionality.

Problem
I started downloading the file after 20%-30% downloads. I click pause then I click resume again. so download starts where is left but then download percentage goes more than 100% like 110,130.

Here is the image on pause.

Screenshot 2021-09-08 at 10 20 20 PM

Here is an image for completion.

Screenshot 2021-09-08 at 10 21 01 PM

What I think the issue is.
So I think when we pause the download we have lastprogress but when I click resume download file is downloading from start again. That is why we are having issues in percentage or maybe some issue in percentage calculations.

Any idea about it.

@jigarfumakiya
Copy link
Author

Hey, @Crdzbird Found the issue!
I Will send PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants