Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It creates the project even if I type n and press enter #124

Closed
4 tasks done
vanodevium opened this issue May 6, 2022 · 6 comments
Closed
4 tasks done

It creates the project even if I type n and press enter #124

vanodevium opened this issue May 6, 2022 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@vanodevium
Copy link
Contributor

Required check list:

  • I'm gonna mark the checkboxes like this.
  • I didn't find in the Create Go App CLI repository's issues section similar bug.
  • I understand, that the Create Go App CLI is Open Source and not-for-profit product.
  • This is not about third-party project, framework, package or technology.

My environment:

  • OS (uname -a): Linux 5.4.0-109-generic #123~18.04.1-Ubuntu SMP Fri Apr 8 09:48:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
  • Golang (go version): go version go1.18.1 linux/amd64
  • Create Go App CLI (cgapp -v): cgapp version 3.6.1

Describe the bug:

Steps to reproduce the behavior:

  1. cgapp create
  2. select fiber
  3. select none
  4. select none
  5. it asks Yes/No, I type n

Expected behavior:
I expect it stop creation, but it creates files:

backend
hosts.ini
Makefile
playbook.yml
roles
@vanodevium vanodevium added the bug Something isn't working label May 6, 2022
@welcome
Copy link

welcome bot commented May 6, 2022

Thanks for opening your first issue here! 👍 Be sure to follow the issue template.

@koddr
Copy link
Member

koddr commented May 12, 2022

Hi,

It's not really a bug. The point here is that the project parts are created independently of each other.

I think that we need to add additional checks at each step so that if an error occurs, delete all parts of the project that have already been created.

If you have time to send such a PR, I will be very glad 😊

@vanodevium
Copy link
Contributor Author

@koddr

I wanted to use cgapp to learn golang programming :))

But I have no choice :) I'll try to figure out how to fix it

@vanodevium
Copy link
Contributor Author

@koddr
Looks like it was a bug after all..
There was no failure check (for NO answer) in the code at all :)

I have added it. Please check.

@koddr
Copy link
Member

koddr commented May 12, 2022

Added in v3.6.2 by merge your PR #126.

Thanks! 👍

@vanodevium
Copy link
Contributor Author

@koddr

Thanks you too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants