Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed without appropriate error on missing node lib. #49

Closed
4 tasks done
SAThomsen opened this issue Dec 21, 2020 · 6 comments
Closed
4 tasks done

Failed without appropriate error on missing node lib. #49

SAThomsen opened this issue Dec 21, 2020 · 6 comments
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@SAThomsen
Copy link

SAThomsen commented Dec 21, 2020

Required check list:

  • I'm gonna mark the checkboxes like this.
  • I didn't find in the Create Go App CLI repository's issues section similar bug.
  • I understand, that the Create Go App CLI is Open Source and not-for-profit product.
  • This is not about third-party project, framework, package or technology.

My environment:

  • OS (uname -a): Darwin Sebastians-MacBook-Pro.local 19.6.0 Darwin Kernel Version 19.6.0: Mon Aug 31 22:12:52 PDT 2020; root:xnu-6153.141.2~1/RELEASE_X86_64 x86_64
  • Golang (go version): go version go1.15.6 darwin/amd64
  • Create Go App CLI (cgapp -v): cgapp version 1.6.10

Describe the bug:

When running cgapp create the initiation of the frontend failed. It failed because I didn't have node installed. A better error message here would improve the UX.
Steps to reproduce the behavior:

  1. Have system without nodejs installed.
  2. Run cgapp create
  3. Notice the sparse error message.

Expected behavior:

A clear error message describing the reason for the error.

Screenshot
image

Cheers!
Thank you for your hard work.

@SAThomsen SAThomsen added the bug Something isn't working label Dec 21, 2020
@welcome
Copy link

welcome bot commented Dec 21, 2020

Thanks for opening your first issue here! 👍 Be sure to follow the issue template.

@koddr
Copy link
Member

koddr commented Dec 21, 2020

Hi, @SAThomsen! Thanks for this UX request.

Yes, I'll make this error message more user-friendly on next version.

@SAThomsen
Copy link
Author

SAThomsen commented Dec 21, 2020

Sounds create thanks @koddr:)! Been playing around with the setup package today. Looks great and I like the vision. Unfortunately I cannot get the setup to show me the React app with cgapp deploy. I get a 200 and a couple of

<pre>
</pre>

tags returned, when hitting localhost. Not sure if I'm doing something wrong here, but I'll need some more experience with the toolbox before I can actually trouble shoot it :)

@koddr
Copy link
Member

koddr commented Dec 22, 2020

@SAThomsen thx for issue :D

But I really have no idea, what's wrong.. can you please record some video or logs or ... for this process?

@stale
Copy link

stale bot commented Jan 6, 2021

👋 Hello. Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 6, 2021
@stale
Copy link

stale bot commented Jan 9, 2021

⚡️ This issue has been automatically closed because it has not had recent activity.

@stale stale bot closed this as completed Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants