Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x3d-canvas xmlns attribute handling #130

Closed
andreasplesch opened this issue Dec 20, 2022 · 3 comments
Closed

x3d-canvas xmlns attribute handling #130

andreasplesch opened this issue Dec 20, 2022 · 3 comments
Labels
bug Something isn't working confirmed The issue can be reproduced fixed The issue is already fixed

Comments

@andreasplesch
Copy link
Contributor

Having two x3d-canvas elements works:

https://raw.githack.com/andreasplesch/Library/f4ee4947aceb3ea3f5477c40fd829a9feeff128c/Tests/Browser/DOMIntegration/in_reflection/dom_inlineReflection.xhtml

But after adding a xmlns attribute to the second canvas, there is an exception:
https://raw.githack.com/andreasplesch/Library/ed9960333fdb60dad2fa7cf2187739f2b57cde27/Tests/Browser/DOMIntegration/in_reflection/dom_inlineReflection.xhtml

Not sure what the correct behavior actually should be but probably the first x3d-canvas should be rendered, and the second one may or may not be properly parsed.

@create3000
Copy link
Owner

  1. It is not possible to add a xmlns attribute to the x3d-canvas element, because it uses the custom-element API from JavaScript. When adding the attribute the API does not recognize the element anymore.
  2. I think, the right place for the xmlns attribute is the X3D element inside. Because the x3d-canvas element is still HTML and not part of the namespace, and X3D, what the namespace includes, starts with X3D root element.

@andreasplesch
Copy link
Contributor Author

It is ok to not recognize and ignore the xmlns namespaced x3d-canvas element. And this is what happens if this is the only x3d-canvas element on the page.

But I believe, it should not have effects on other x3d-canvas elements on the same page if there are multiple. It is not a critical issue since it would be very rare that somebody would try do that.

@create3000
Copy link
Owner

That's right, there must not be an exception. Now, X_ITE silently ignores such elements.

@create3000 create3000 added bug Something isn't working fixed The issue is already fixed confirmed The issue can be reproduced labels Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed The issue can be reproduced fixed The issue is already fixed
Projects
None yet
Development

No branches or pull requests

2 participants