Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getAsyncId() return 0 instead of false #43

Merged
merged 1 commit into from
Sep 21, 2017
Merged

getAsyncId() return 0 instead of false #43

merged 1 commit into from
Sep 21, 2017

Conversation

Jimbly
Copy link
Collaborator

@Jimbly Jimbly commented Sep 21, 2017

This fixes #40, crashing on Node v8.5.0 which has more strict checks on "async ids".

This fixes #40, crashing on Node v8.5.0 which has more strict checks on "async ids".
@Jimbly Jimbly merged commit 4c27a07 into master Sep 21, 2017
@Jimbly Jimbly deleted the fix_async_id branch September 21, 2017 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http-parser-js causes node8.5 to crash with ERR_INVALID_ASYNC_ID error
1 participant