Fix remove to not hang when the resource doesn't exist.

creationix · Jun 29, 2010 · badf861 · badf861
1 parent c281176
commit badf861
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/nstore.js b/lib/nstore.js
@@ -250,6 +250,10 @@ function nStore(filename) {
         dbLength += line.length;
         queueSize += line.length;
         checkQueue();
+      } else {
+          var err = new Error("Cannot delete a document that does not exist");
+          err.errno = process.ENOENT;
+          callback(err);
       }
     },
 

diff --git a/test/removeTest.js b/test/removeTest.js
@@ -25,3 +25,10 @@ users.remove("creationix", function (err) {
     assert.ok(meta, "meta loaded");
   });
 });
+
+expect("fail");
+users.remove("baduser", function (err) {
+    fulfill("fail");
+    assert.ok(err instanceof Error, "error is an Error");
+    if (err.errno !== process.ENOENT) throw err;
+});