Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DarkTurquoise to ForestGreen #72

Merged
merged 7 commits into from
Aug 19, 2020

Conversation

Aakash2408
Copy link
Contributor

Fixes

Fixes #62 by @panchovm

Description

Replaced DarkTurquoise with ForestGreen across all site

Technical details

ForestGreen:RGB(4,166,53)

Screenshots

Screenshot from 2020-08-19 00-00-21

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Aakash2408 Aakash2408 requested a review from a team as a code owner August 18, 2020 18:34
@Aakash2408 Aakash2408 requested review from krysal and removed request for a team August 18, 2020 18:34
@Aakash2408 Aakash2408 mentioned this pull request Aug 18, 2020
3 tasks
@Aakash2408
Copy link
Contributor Author

I guess there are again issues.I reforked the repository after deleting the old one and still facing this issue

@kgodey kgodey changed the base branch from master to develop August 18, 2020 18:48
@kgodey
Copy link
Member

kgodey commented Aug 18, 2020

@Aakash2408 you're fine, I updated the branch again. You need to select the correct branch when making the PR in GitHub.

@kgodey
Copy link
Member

kgodey commented Aug 18, 2020

It doesn't look like the changes showed up, though.

@Aakash2408
Copy link
Contributor Author

Aakash2408 commented Aug 18, 2020

It doesn't look like the changes showed up, though.

I will just check in local

@Aakash2408
Copy link
Contributor Author

There are done in my local repo
Screenshot from 2020-08-19 00-22-49

@Aakash2408
Copy link
Contributor Author

Aakash2408 commented Aug 18, 2020

Why the test is failing @kgodey :(

@TimidRobot
Copy link
Member

Why the test is failing @kgodey :(

I'm not 100%, but I think the test is failing due to secrets not being available to forks (a known issue with PRs from forks: actions/checkout#298 (comment))

@TimidRobot TimidRobot self-assigned this Aug 18, 2020
@TimidRobot TimidRobot added bug and removed bug labels Aug 18, 2020
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! Just a few changes:

  • On home page and Scholarship list page, the scholarship cards should change the background color too (has-background-forest-green).

I didn't know about the secrets not available for forks ❗ we'll look at that apart but your code is running okay.

@@ -207,7 +207,7 @@ a, a:hover {
}

footer a:hover {
color: $color-dark-turquoise;
color: $color-forest-green;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must keep the turquoise color.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok i will look into it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must keep the turquoise color.

do I only need to change it back to dark-turquoise on the hover on the footer

@Aakash2408
Copy link
Contributor Author

Why the test is failing @kgodey :(

I'm not 100%, but I think the test is failing due to secrets not being available to forks (a known issue with PRs from forks: actions/checkout#298 (comment))

Yes I guess the secret_key is not set.

@Aakash2408
Copy link
Contributor Author

@krysal @TimidRobot Can you kindly review the changes in code, am not sure about this test?

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@krysal krysal merged commit 9fdb32a into creativecommons:develop Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace DarkTurquoise with ForestGreen across all site
4 participants