Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug in order book and pool orders calculation #323 #39

Merged
merged 3 commits into from
Jul 4, 2022
Merged

fix: bug in order book and pool orders calculation #323 #39

merged 3 commits into from
Jul 4, 2022

Conversation

kingcre
Copy link
Contributor

@kingcre kingcre commented Jul 4, 2022 •
edited

Description

Tasks

References

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@hallazzang @kingcre
fix: bug in order book and pool orders calculation
97fe7d5 
- do not add order with zero matchable amount to order book
- check if result of `BuyAmountTo`/`SellAmountUnder` is positive
- set matched to true only when order distribution has happened

(cherry picked from commit 5b39230)
@hallazzang @kingcre
fix: bug in pool order amount calculation
63779cf 
(cherry picked from commit caf8730)
@hallazzang @kingcre
test: add test
2edeba2 
(cherry picked from commit 7862555)
@kingcre kingcre self-assigned this Jul 4, 2022
@kingcre kingcre marked this pull request as ready for review July 4, 2022 10:46
@crypin crypin merged commit 4260515 into main Jul 4, 2022
@kingcre kingcre deleted the cherry-pick/323 branch August 1, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crypin crypin crypin approved these changes

@queencre queencre Awaiting requested review from queencre

Assignees

@kingcre kingcre

Labels
x/liquidity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kingcre @crypin @hallazzang