Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency rome to v12 #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deps): update dependency rome to v12 #4

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Mar 28, 2023 •
edited
Loading

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rome (source) 11.0.0 -> 12.1.3 age adoption passing confidence

Release Notes

rome/tools

v12.1.3

CLI
Other changes
  • rome lsp-proxy should accept the global CLI options #​4505
  • Enhance help descriptions
Configuration
Other changes
  • Fix an issue where all the nursery were enabled when the "nursery": {} object
    was defined #​4479
Formatter
Linter
Other changes
Parser
Other changes

v12.1.2

Configuration
Other changes
  • Fix regression where a specific combination of configuration didn't load
    the correct rules to apply #​4502
Linter
New rules
Other changes
  • noInnerDeclarations: allow function declarations in nested block inside an ES module #​4492.
  • noInvalidConstructorSuper: recognize extends clauses that use static member access such as extends mod.C #​4499

v12.1.1

CLI
Other changes
  • Fix regression where the command lsp-proxy was renamed lsp_proxy #​4489
Configuration
Other changes
  • Fix an issue where Rome was loading incorrectly recommended rule #​4479 #​4488
Linter
Other changes
  • Fix an issue where the noAssignInExpressions rule replaced the operator with an invalid token, which caused other lint rules to crash. #​4464
  • Fix an issue that noUnusedVariables rule did not correctly detect exports when a variable and an interface had the same name #​4468

v12.1.0

CLI
Other changes
  • Refactored the underling argument parsing logic. Changed the look and feel of the help
    output. #​4405.
  • The command rome check can accept input from stdin.
  • Add the argument --stdin-file-path to use when running rome check via stdin.
  • Add the argument --formatter-enabled to the command rome check to control the formatter via CLI.
  • Add the argument --linter-enabled to the command rome check to control the linter via CLI.
  • Add the argument --organize-imports-enabled to the command rome check to control the import sorting via CLI.
  • Add new command rome migrate the transform the configuration file rome.json
    when there are breaking changes.
Configuration
  • Add vcs property, to opt in the VCS integration:
    • vcs.enabled, to enable or not the integration;
    • vcs.clientKind, the supported clients;
    • vcs.useIgnoreFile, to ignore the files/paths inside the file;
    • vcs.root, an optional path to the root of the VCS;
Editors
Other changes
  • Fix an issue where the VSCode extension duplicates text when using VSCode git utilities #​4338
  • Remove code assists from being added to the code actions when apply fixes;
  • When requesting code actions, ignored files should not throw errors. Fixes #​4434
Formatter
Other changes
  • Fix an issue where formatting of JSX string literals property values were using incorrect quotes #​4054
  • Changed import assertion grammar to the new import attribute assertion
- import "module" assert {}
+ import "module" with {}
  • Fix an issue where JSON formatter does not respect lineWidth for arrays #​4351
  • Add support for decorators
Linter
New rules
Promoted rules

New rules are promoted, please check #​4431 for more details.

Note that, noExtraSemicolons and noExtraLabels are renamed to noExtraSemicolon and noUselessLabel.

Other changes
  • Code actions are formatted using Rome's formatter. If the formatter is disabled,
    the code action is not formatted.
  • Fixed an issue that useShorthandArrayType rule did not handle nested ReadonlyArray types correctly and erroneously reported TsObjectType #​4354.
  • noUndeclaredVariables detects globals based on the file type.
  • Fix an issue when noUndeclaredVariables incorrectly identifies AggregateError as an undeclared variable. #​4365
  • Fix an issue that useLiteralKeys rule doesn't ignore valid uses of square bracket notation. #​4370
  • Fix #​4348 that caused noNonNullAssertion to emit incorrect code action
  • Fix #​4410 that caused useButtonType to miss some cases
  • Fix false positive diagnostics that useCamelCase caused to default exported components
  • Fix false positive diagnostics that useCamelCase caused to private class members
  • Fix false positive diagnostics that useHookAtTopLevel caused to arrow functions, export default functions and function expressions.
  • Fix false positive diagnostics that useHookAtTopLevel caused to as or satisfies expression.
  • Fix false positive diagnostics that noHeadeScope caused to custom components
  • Fix false negative diagnostics that noNoninteractiveElementToInteractiveRole and noNoninteractiveTabindex caused to non-interactive elements.
Parser
Other changes
  • Allow module syntax in cts files
  • Changed import assertion grammar to the new import attribute assertion
- import "module" assert {}
+ import "module" with {}
  • Allow decorators before export and export default. #​4252
  • Add support for Stage 3 decorators
VSCode
  • requireConfiguration is set to true by default

v12.0.0

CLI
Breaking changes
  • Review how the traversal of the file system works. Now Rome won't navigate folders that are ignored.
    While this change is a bug fix, this could affect how the ignore entries are defined inside a project. We suggest to review them
    and make sure they still work.
  • --apply-suggested is now called --apply-unsafe
  • rome check --apply and rome check --apply-unsafe exits with non-zero code (error code)
    if there are still diagnostics to be addressed.
Other changes
  • rome check now checks import statements. This is an experimental feature that needs to be
    enabled via configuration. Import can be sorted using rome check --apply-unsafe
  • Rome is able to auto discover the configuration file. If Rome doesn't fine a configuration in the
    working directory, it will try to find one in the parent directories.
  • Add a new global options called --config-path. It tells Rome to try and discover a rome.json file
    in the given path. 
    rome format --config-path=../../other/path/
rome check --config-path=../../other/path/
Configuration
Other changes
  • Rome now uses the internal JSON parser to validate the configuration file. This means Rome won't
    exit anymore if there are issues with the rome.json file, instead it will apply its defaults
    to the sections that are incorrect.
  • Add javascript.organizeImports. This is an experimental feature and users need to opt-in.
{
  "organizeImports": {
    "enabled": true,
    "ignore": ["trickyFile.js"]
  }
}
  • Add linter.rules.all and linter.rules.[group].all. These options allow to enable or disable all
    rules, or all rules for a given group. all and recommended can't be both true.
{
  "linter": {
    "rules": {
      "all": true,
      "style" : {
        "all": false
      }
    }
  }
}

The previous example will enable all rules and disable all rules that belong to the style group.

Editors
Other changes
  • Add support to display diagnostics for JSON files.
  • Add support to format JSON files.
  • Pull diagnostics when parsing a rome.json file.
  • Imports sorting is not applied for files that are not supported or ignored.
Formatter
  • Add support for JSON files
  • Add support for TypeScript 4.7
  • Add support for TypeScript 5.0
Linter

New rules are promoted, please check #​4239 for more
details.

Parser
  • Support for TypeScript 4.7
  • Support for TypeScript 5.0
VSCode
Other changes
  • Add a new option called requireConfiguration. Enabling this option will force Rome to require
    a configuration file in your workspace/project. If Rome doesn't find a rome.json file, it won't
    emit diagnostics.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from elijaholmos as a code owner March 28, 2023 15:10
@renovate renovate bot force-pushed the renovate/rome-12.x branch 2 times, most recently from 15a8542 to 01a7fed Compare May 18, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elijaholmos elijaholmos Awaiting requested review from elijaholmos elijaholmos is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants