Added Background Color Support #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added background color support for scenes that aren’t filling the entire frame in sprites. The idea for setting a custom color in the transparency was from jpdev. I just removed the selectable color, and just made it the current background color for simplicity.
| tempGraphic.lineStyle(1,this.game.stage.backgroundColor, 1); | ||
| tempGraphic.drawRect(0, 0, this.game.width, this.game.height); | ||
| tempGraphic.endFill(); | ||
| this._texture.renderXY(tempGraphic, 0, 0); //adding it to the texture before the world render |
There was a problem hiding this comment.
Can you move the comments above the execution line. I'm just nit-picking.
|
Awesome work! See my comment, do changes and I'm gonna merge it |
added 2 commits
February 27, 2015 03:24
Moved comment above line
Other comment
|
Comments moved! |
cristianbote
added a commit
that referenced
this pull request
Feb 27, 2015
Added Background Color Support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added background color support for scenes that aren’t filling the entire frame in sprites.
The idea for setting a custom color for the transparency of the transition was from jpdev.
I just removed the selectable color, and just made it the current background color for simplicity.