Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Prometheus Endpoint for Template Rendering Times #81

Closed
MillsyBot opened this issue Nov 18, 2021 · 2 comments
Closed

[FEATURE] Prometheus Endpoint for Template Rendering Times #81

MillsyBot opened this issue Nov 18, 2021 · 2 comments

Comments

@MillsyBot
Copy link

Hey Criteo!

This is an amazing product, we have been using it for over a year to render large and extra-large pools. The one thing that we are missing from this product is away to view statistics on each template including: reloads, render times, failures (if any, we generally code around missing values, but being able to notify prometheus would be great).

Again, this awesome, hope this is a reasonable ask! Have a great holiday!

@pierresouchay
Copy link
Contributor

pierresouchay commented Nov 18, 2021

Hello @MillsyBot ,

The tool is actually able to expose prometheus metrics, not with http natively, but by exposing a file compatible with prometheus metrics. Such file can then be exposed using your favorite HTTP server.
Here is an example in samples on how doing that :
https://github.com/criteo/consul-templaterb/blob/master/samples/metrics.erb

Did you already had a look?

It already exposes quite a few technical information about consul-templaterb (such as bytes, errors and so on...)

If you require more info than what is already exposed, maybe it could be possible to add more information if you come with a specific list.

Note: there are many other examples of various prometheus exports (RTT between agent nodes, DCs...) in https://github.com/criteo/consul-templaterb/blob/master/samples/

Regards

@MillsyBot
Copy link
Author

This is great. THanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants