-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Mockito 2.X #33
Conversation
RC1 was just released. Might be worth updating to at least the RC1. |
@eygraber Mockito 2.1 has reached non-beta. Could you update to the full release? |
Nice. |
if(Modifier.isFinal(type.getModifiers())) { | ||
return "final or anonymous class"; | ||
} | ||
return "\nnot handled type"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the \n
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure ¯_(ツ)_/¯
I think it's safe to take it out.
@@ -42,7 +42,7 @@ | |||
<dependency> | |||
<groupId>org.mockito</groupId> | |||
<artifactId>mockito-core</artifactId> | |||
<version>1.10.5</version> | |||
<version>2.1.0-beta.120</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can use the non-beta version since its a full release build now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, forgot about this PR.
@swankjesse @jpshelley fixed |
I'm getting an exception 🤔 Using it with kotlin 1.0.4 throught jitpack (
|
No description provided.