Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build system #231

Closed
Tracked by #275
adamjanovsky opened this issue Jun 8, 2022 · 0 comments · Fixed by #294
Closed
Tracked by #275

Improve build system #231

adamjanovsky opened this issue Jun 8, 2022 · 0 comments · Fixed by #294
Assignees
Labels
CI/CD Stuff related to tests, deployment, docker, ... refactoring Need to cleanup and refactor

Comments

@adamjanovsky
Copy link
Collaborator

There are two caveats in the current build system:

  • setup.py is favored instead of nowadays preferred setup.cfg. We can use pip-tools to read unpinned requirements directly from setup.cfg (which is the only dynamic stuff we currently use setup.py for
  • Tests are run with pinned dependencies against source (not installed version of sec-certs). Since we forecast that our tool will be mainly used as a library (not application, we run it in reproducible environment) it would make sense to run tests against installed version. This is easily achieved by creating the top-level module sec-certs into un-importable directory src/ as nowadays adopted by majority of Python projects.

Some reading:

@adamjanovsky adamjanovsky added CI/CD Stuff related to tests, deployment, docker, ... refactoring Need to cleanup and refactor labels Jun 8, 2022
@adamjanovsky adamjanovsky self-assigned this Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Stuff related to tests, deployment, docker, ... refactoring Need to cleanup and refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant