Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CommonCriteria files -> cc #287

Closed
Tracked by #275
adamjanovsky opened this issue Dec 2, 2022 · 4 comments · Fixed by #295
Closed
Tracked by #275

Rename CommonCriteria files -> cc #287

adamjanovsky opened this issue Dec 2, 2022 · 4 comments · Fixed by #295
Assignees
@adamjanovsky
Labels
cc Related to CC certification refactoring Need to cleanup and refactor

Comments

@adamjanovsky
Copy link
Collaborator

Filenames of common_criteria*.py should be renamed to cc*.py.

@J08nY Would you like to rename also classes? E.g. CommonCriteriaCert to CCCertificate? We're not consistent there as well.
@adamjanovsky adamjanovsky added refactoring Need to cleanup and refactor cc Related to CC certification labels Dec 2, 2022
@adamjanovsky adamjanovsky self-assigned this Dec 2, 2022
@adamjanovsky adamjanovsky mentioned this issue Dec 2, 2022
Merged
51 tasks
@adamjanovsky
Copy link
Collaborator Author

@J08nY what do you think about CommonCriteriaCert -> CCCertificate? Three Cs in a row seem a lot :D But we have CCDataset, FIPSDataset, FIPSCertificate, and then we have CommonCriteriaCert ...

@J08nY
Copy link
Member

J08nY commented Dec 9, 2022

Go for it.

Special cases aren't special enough to break the rules.

  • Zen of Python

@adamjanovsky
Copy link
Collaborator Author

PEP 8 strikes back 😆

A Foolish Consistency is the Hobgoblin of Little Minds

@J08nY
Copy link
Member

J08nY commented Dec 9, 2022

I would still go for it CCCertificate is not unreadable I think.

@adamjanovsky adamjanovsky mentioned this issue Dec 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamjanovsky adamjanovsky

Labels
cc Related to CC certification refactoring Need to cleanup and refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue/287 rename common criteria files crocs-muni/sec-certs
2 participants
@J08nY @adamjanovsky